Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#47 closed enhancement (fixed)

time stamp should be kept when replying

Reported by: jms@… Owned by: rene
Version: 0.5.0 Keywords: time stamp
Cc:

Description

When I write a new mail with the "time stamp" option active, the From: address becomes jms1207839294@… .

If the receiver replies, I get a mail from him addressed to jms1207839294@… .

When I reply now, the From: address is jms@… . The timestamp should be kept or a new one should be generated.

Change History (18)

comment:1 Changed 14 years ago by rene

Owner: set to rene
Status: newassigned

Hi,

you are right, the timestamp should be kept. To do this you have to options, the Smart-Reply feature might recognize the address to which you received the mail and use it automatically. Or the extension might look up in the Storage, where - if you activated the saving of Virtual Identities - it should find the Identity you used for the last email to the recipient. In both cases the Identity with the timstamp should be used. So in theory it works :) Please activate the debug-output in virtual identities preferences and post the output found in the MessageComposeWindow? after starting a reply. (A possible problem might occur if for the related recipient a different senders Identity was stored before, the former one will be used with the default options).

Regards, Rene

comment:2 Changed 14 years ago by anonymous

I switched off storing of addresses since I assumed time stamps are always generated.

Would it be possible to generate a new time stamp in this case?

comment:3 Changed 14 years ago by rene

New timestamps are only generated if you compose a new email. And for sure, you can just compose a new email and copy-paste the sender identity to the reply mail (but somehow I have the feeling thats not what you want). So, the Smart-Reply feature still should be able to retrieve the address which was used to send you the mail in most cases. Just have a look in the source of the mail and search for the header which contains you identity. Than configure Smart Reply the right way (set it to recognize this header, use the debug feature to see if it finds it) and it should use the previous timestamp.

Regards, Rene

PS: If you have trouble to find a way, just post as much as your privacy concerns allow out of the headers of the mail (or a typical mail) you received, i can probably tell you which header to use than.

comment:4 Changed 14 years ago by anonymous

I activated "smart reply", I did not active "save identities".

Debug says: ## vI_smartIdentity: add new address to result:Jens Martin Schlatter <jms1207845327@…> ## vI_smartIdentity: merged SmartReply? & Storage, 1 address(es) left ## vI_smartIdentity: search for preselected Identity ## vI_smartIdentity: preselected email: jms@… ## vI_smartIdentity: preselected name: jens martin schlatter ## vI_smartIdentity: collected address(es) doesn't contain preselected Identity, continuing ## vI_smartIdentity: check if any collected address is stored as a (usual) Identity ## v_identity: NotifyComposeBodyReady?

So it finds the correct To: address, but does not get the match.

comment:5 Changed 14 years ago by rene

right, it finds the address. seems like a real bug, cause there should be a message like "found existing Identity in address sets, aborting" or "no collected address found stored, continuing" after the "check if any collected address is stored as a (usual) Identity" message. So please check the "Error Console" (at the tools menu), clear the console, start the reply again and check for errors.

Regards, Rene

comment:6 Changed 14 years ago by jms@…

error console says: Error: server has no properties Source File: chrome://v_identity/content/vI_smartIdentity.js Line: 170

comment:7 Changed 14 years ago by jms@…

I wonder why in the line ## vI_smartIdentity: preselected name: my name is written in lowercase.

Everywhere in TB the name is written with capitals.

comment:8 Changed 14 years ago by jms@…

Ok hab jetzt angekreuzt "smart reply for newsgroups", dann läuft er nicht in den fehler in zeile 170 und dann geht es!

ignore newsgroup accounts if not selected in preferences if (!vI.preferences.getBoolPref("smart_reply_for_newsgroups") && server.type == "nntp") continue;

comment:9 Changed 14 years ago by rene

Right, it's a nice fast (ugly) workaround :)

The error says that there is a account without an incoming server in your preferences. This is strange and shoudn't happen. Older versions of Virtual Identity (pre 0.5) created temporary 'Virtual Identity' Accounts which didn't contained an incoming server. (Newer versions use a slightly different approach.) Those temporary accounts should be automatically removed after used for sending an email - which might have gone wrong.

For debugging reasons the content of your preferences file will be interesting. In your Profile-Folder, the file prefs.js. It contains the whole configuration, interesting are the lines starting with (the other might contain private data):

user_pref("mail.account.
user_pref("mail.accountmanager.accounts
user_pref("mail.server.serverX.type  --  where X is >=0

Please check additionally if your Account Settings for any 'Virtual Identity' accounts (should be safe to remove them - if you haven't stored some Mails in possibly shown 'Virtual Identity' account folders).

Regards, Rene

comment:10 Changed 14 years ago by jms@…

var server = accounts[i].incomingServer;

What is incomingServer? Where does this property come from?

comment:11 Changed 14 years ago by rene

Hi,

the incomingServer is a part of every account and is usually created with the Wizard while adding new account. Usually you don't need an 'incomingServer' for sending mails, so I ignored the incomingServer in older VirtualIdentity versions. For Newsposts this didn't work, cause the incomingServer is the newsServer which is required too for sending the mails. So I changed this behavior in the current releases. But anyway, those VirtualIdentity-Accounts should be removed by the extension after sending any email, there might be an other reason for the missing incomingServer.

Regards, Rene

comment:12 Changed 14 years ago by jms@…

I thought that maybe the property "incomingServer" is wrong. The error message says "server has NO properties". No properties at all! This means the variable "server" is not filled with the server.

I checked my prefs.js and found only normal entries. Every account has assigned a server name and all server names have definitions of their properties.

comment:13 Changed 14 years ago by rene

Resolution: fixed
Status: assignedclosed

No, the variable Name is right (see http://www.xulplanet.com/references/xpcomref/ifaces/nsIMsgAccount.html ) But should usually never be empty (unset), don't know what happened. Just fixed all possible problems with [178]. You can try the checkout of the upcoming version (http://absorb.it/software/virtual_identity/daily/virtual-identity_rev178_2008-04-12.xpi), but it's a work-in-progress beta with some other changes too.

Closed by now, if you have some additional info just reopen. Regards and thanks for the report, Rene

comment:14 Changed 14 years ago by jms@…

Can we debug it by writing out variable "server"?

How do I write it out and where do I have to store the changed .js ?

comment:15 Changed 14 years ago by rene

As the error says, 'server' has no properties - which means it is not set at all. So there is/was obviously an account which had no incomingServer registered, therefore the account might be more interesting than the non-existant incomingServer.

To debug the values of the variable you can use any of the following code:

alert(server)
alert(server.hostName)
alert(account)
alert(account.key)
// or to see it in the debug-log
vI_notificationBar.dump("## account   " + account.key +"'\n")
vI_notificationBar.dump("## server:   " + server.hostName +"'\n")

To change this file and re-build the extension on your own have a look at the development info.

comment:16 Changed 14 years ago by jms@…

In mail.accountmanager.accounts is listed an account which does not exist, i.e. this account name is only in mail.accountmanager.accounts and it is not used in any other places.

comment:17 Changed 14 years ago by jms@…

Fix:

var server = accounts[i].incomingServer; if (null == server) continue; /* continue if server is null */

comment:18 Changed 13 years ago by anonymous

hallo, diese seite ist öffentlich über google findbar und zeigt email-adressen von mir. ist es möglich, die rauszunehmen oder zu verändern? ich möchte keine spamflut auf diese adressen. danke! jens martin schlatter

Note: See TracTickets for help on using tickets.